Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yellow text on white background is unreadable #75

Closed
tillydray opened this issue Oct 26, 2020 · 2 comments
Closed

Yellow text on white background is unreadable #75

tillydray opened this issue Oct 26, 2020 · 2 comments

Comments

@tillydray
Copy link

tillydray commented Oct 26, 2020

Screen Shot 2020-10-26 at 14 32 41

I'm sure this isn't intentional, unfortunately I'm not sure what package causes that yellow text. Is there a way for me to find out? I believe it's tide, as in Typescript IDE.

EDIT: Just to clarify, I'm talking about the yellow text on the right side of the screenshot

@fniessen
Copy link
Owner

Dear JasonMFry, not such a thing is not intentional... But I dunno tide...

Can you do C-u C-x = to find out the name of the face in question, and eventually propose a color for it?

@tillydray
Copy link
Author

I use Doom Emacs in case that's relevant here. It's either:

  • mode-line-highlight
  • lsp-modeline-code-actions-preferred-face
  • lsp-ui-sideline-code-action

The following two faces have the same yellow on white:

  • doom-modeline-panel
  • diredfl-compressed-file-suffix

I propose all 5 of those faces have #FFF68F background with #000000 text
image

This is the same as popup-summary-face, but I like it because yellow is usually a warning or information, and if these 5 faces are trying to convey information or a warning, we should keep yellow, but to make it accessible the font should be black. I think this would work on both light backgrounds and dark backgrounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants