-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split functionality in lib and CLI #40
Conversation
…ort for "clocker start"
…tibility with clocker@1
@fnogatz I will have a look at your changes as soon as I have a free timeslot for that. 👍 |
Yes, but only a quick look. Sorry for that. I hope that I can give you some detailed feedback next week. 🙈 |
@BeniRupp, ping 😀 |
I'am so sorry! My smartphone reminds me every other day.. 😞 |
Soo.. I had the change to have a look at your PR this evening. 🙂 First of all, I like the refactoring you made! To use One thing that I would reconsider is the length of the files. I prefer short files for a better overview and to separate things that belong together from those which do not. So my suggestion is:
I think this would really improve the readability. I will also add some comments to the code to point out some smaller things I found during the review. Hopefully this feedback is useful for you. If I am wrong with one of my comments, please let me know! 😉 |
Hey @fnogatz, thank you for the rework! 🙂 |
There's still one major point from your original post:
I see your point in splitting the large files. However, my urge to refactor this is not too big 😆 But I am open to your suggestions. Maybe it's a good idea to merge this first, and then you could open a PR with the changes, if you are still interested in? I will happily merge it :) |
Sounds good! 👍 Let's do it this way. |
Haha, thanks for merging this. I once asked @substack to give you the permissions for this repository, but he never responded. So you are also able to publish the new version at npm? |
Yes, he gave it to me. 🙂 Oh, I've never done this. Is it just a |
I just removed the legacy |
As first discussed 3 years ago in #26, I just started to move the core functionality into a
/lib/index.js
file, so we can split into a library and the CLI. This also allows to provide TAP tests for future development.