Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudshell support #607

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Add Cloudshell support #607

merged 4 commits into from
Mar 11, 2020

Conversation

roroco
Copy link
Contributor

@roroco roroco commented Mar 9, 2020

  • Pickup version of fn go with support for cloudshell provider
  • Read oci cli auth environment variable to determine what oracle provider to use

@roroco roroco requested a review from srpurani March 9, 2020 17:48
config/config.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@roroco
Copy link
Contributor Author

roroco commented Mar 9, 2020

Addressed comments.

Copy link
Member

@srpurani srpurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OracleCSProvider is driven by OCI Auth variable. Would be ideal to separate signing mechanics from CS specific default logic.

go.mod Outdated Show resolved Hide resolved
@roroco roroco requested review from jan-g and zootalures March 10, 2020 00:48
@roroco
Copy link
Contributor Author

roroco commented Mar 11, 2020

OracleCSProvider is driven by OCI Auth variable. Would be ideal to separate signing mechanics from CS specific default logic.

I think we can reorganize when there is a case where the token is available outside of a cloudshell environment. But to do so later, we probably need to expand the criteria for when the cloudshell provider is chosen as the default provider i.e. use not just the value of oci_cli_auth but additional environment specific properties.

@srpurani
Copy link
Member

OracleCSProvider is driven by OCI Auth variable. Would be ideal to separate signing mechanics from CS specific default logic.

I think we can reorganize when there is a case where the token is available outside of a cloudshell environment. But to do so later, we probably need to expand the criteria for when the cloudshell provider is chosen as the default provider i.e. use not just the value of oci_cli_auth but additional environment specific properties.

Makes sense, we can refactor this when the need arises.

Copy link
Member

@srpurani srpurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@srpurani srpurani merged commit c9b0e18 into master Mar 11, 2020
@mrc mrc deleted the cloudshell-support branch March 13, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants