-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudshell support #607
Conversation
roroco
commented
Mar 9, 2020
- Pickup version of fn go with support for cloudshell provider
- Read oci cli auth environment variable to determine what oracle provider to use
Addressed comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OracleCSProvider is driven by OCI Auth variable. Would be ideal to separate signing mechanics from CS specific default logic.
I think we can reorganize when there is a case where the token is available outside of a cloudshell environment. But to do so later, we probably need to expand the criteria for when the cloudshell provider is chosen as the default provider i.e. use not just the value of oci_cli_auth but additional environment specific properties. |
Makes sense, we can refactor this when the need arises. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.