Added support for java version 17 in cli #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +83,8 @@ func (h *JavaLangHelper) RunFromImage() (string, error) { | |||
| return fmt.Sprintf("fnproject/fn-java-fdk:%s", fdkVersion), nil | |||
| } else if h.version == "11" { | |||
| return fmt.Sprintf("fnproject/fn-java-fdk:jre11-%s", fdkVersion), nil | |||
| } else if h.version == "17" { | |||
| return fmt.Sprintf("fnproject/fn-java-fdk:jre17-%s", fdkVersion), nil | |||
There was a problem hiding this comment.
that's a good time to stop naming something as JRE, this concept is no longer valid for Java since JDK 11.
There was a problem hiding this comment.
What can it named as we are having a concept of creating two images. One for the build image and other for the run image so it is not exactly the jre but the run image for the fdk
There was a problem hiding this comment.
Thanks for your suggestion. We are going to pick this up in future https://jira.oci.oraclecorp.com/browse/FAAS-7797
theatul
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.