Revert "safe responsewriter usage in TryExec (#1490)" #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1fb78ed.
bharadwr
pushed a commit
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1fb78ed.
Link to issue this resolves
This PR reverts safe responsewriter usage in TryExec #1490
What I did
git revert 1fb78ed
How I did it
git revert 1fb78ed
How to verify it
Ensure tests are passing.
One line description for the changelog
Revert safe responsewriter usage in TryExec #1490 as this was breaking detached function calls. The new code was writing http response to a copy of response writer, which prevented the lbagent from responding to its client early.
One moving picture involving robots (not mandatory but encouraged)