Fix deps #200
Merged
Fix deps #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 3, 2017 03:50
the docker one actually sucks to use, as apparent here. had to add a lot of shit just for it to work, but the heroku registry client has gone stale and is causing issues with our dependencies. didn't expect this to be that hard, but it's over now. good thing we aren't even using this code ^_^. we need to at some point start limiting image sizes and remember this not being fun to figure out to begin with, so anyway, now this works and we don't have to wrestle with different versions of docker in deps (hopefully) anymore.
had to lock a lot of things in place
|
going to update w/ #191 stuff meow |
|
ok, updated. looks good now (i think). should review 5bfc043 mostly |
|
bump @denismakogon @oracloud |
denismakogon
approved these changes
Aug 9, 2017
|
@oracloud your turn. |
|
@rdallman @denismakogon CircleCI is happy. LGTM. |
ghost
approved these changes
Aug 9, 2017
ghost
merged commit
|
thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5bfc043 does some work to actually get rid of the heroku registry client. the latter commit updates the deps. since our deps are broken if we don't strip the vendor directory and without getting rid of heroku, they were broken with stripping, too (p.s. we shouldn't have to strip vendor for our deps to work)
the
clipackage was not properly being omitted from the top levelfndeps anymore, so this removes a lot of deps from that too.the sirupsen thing was broken again too. it seems like we basically need to wait for all of our deps to update to lower case and then we can update to lower case. until then, we need to keep upper case versions of everything that uses logrus vendored. (yes, seriously). there are good rants to be found here: sirupsen/logrus#570 (comment) . so for the moment, had to add some old versions of things that updated to lower case sirupsen until we are ready. :(((((((((((((((
if we get this in before #191 i'll rebase and update deps there, or if vice versa i'll remove them here.
just think of all the fun ya'll missed since we have vendor vendored ^_^
these are seriously a disaster to maintain, and idk what to do about it (and that has nothing to do with whether we download them or not. updating them is impossible and happening all the time is the issue. and sirupsen. definitely sirupsen. and docker too) should we freeze everything at its current state?