Rework the persistence mechanism of private C functions. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I worked on this refactoring a long time ago because I wanted to keep track of my Lua patches more easily. I don’t know if it’s useful to you or if you prefer the current way of doing things, but I thought I’d share the idea anyway. |
This modification takes the number of modified Lua files from 8 down to 3 and makes the patch slightly less intrusive.
samhocevar
force-pushed
the
refactor-macros
branch
from
5588a30
to
7ebf861
Compare
|
Would you be willing to migrate your pull requests over to https://github.com/MovingBlocks/eris ? That repository is a bit more maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification takes the number of modified Lua files from 8
down to 3 and makes the patch slightly less intrusive.