Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package was restored using .NETFramwork=v4.6.1 #1318

Closed
hashitha opened this issue Jan 30, 2022 · 8 comments · Fixed by #1610
Closed

Package was restored using .NETFramwork=v4.6.1 #1318

hashitha opened this issue Jan 30, 2022 · 8 comments · Fixed by #1610

Comments

@hashitha
Copy link

I am getting the following when I added fo-dicom.Imaging.Desktop 5.0.2 to a .NET 6 WPF app. The app seems to work fine.

image

@hashitha hashitha added the new label Jan 30, 2022
@tpst
Copy link

tpst commented Feb 9, 2022

I'm also getting this. I would like to know if this is something to be concerned about.

@gofal
Copy link
Contributor

gofal commented Feb 9, 2022

the package fo-dicom.imaging.desktop requires System.Drawing. Is there any issue with System.drawing and .net 6? Will GDI be deprecated in .net 6 and replaced by some other packages?
I have not started to use .net6 so far, because it would require to switch my whole IDE-ecosystem, so I do not have personal experience. But System.Drawing is the only package referenced by fo-dicom.imaging.desktop and not by fo-dicom.core.

@hashitha
Copy link
Author

hashitha commented Feb 9, 2022

I am not sure about what is happening with GDI but VS2022 runs so much faster so it is worth the upgrade if you have a lot of ram.

@mrbean-bremen
Copy link
Collaborator

Maybe the warning has to do with the fact that System.Drawing is only supported under Windows since .NET 6. If fo-dicom only supports Windows, this should not be an issue.

@gofal
Copy link
Contributor

gofal commented Feb 9, 2022

Oh, i thought System.Drawing was always only supported under Windows. That's why it is only included in the nugetpackage fo-dicom.Imaging.Desktop, while on all other platform it is recommended to use fo-dicom.Imaging.ImageSharp, or no package at all and use the byte-arrays of pixels directly (RawImage).

@gofal
Copy link
Contributor

gofal commented Feb 9, 2022

If you are using fo-dicom.imaging.desktop, then you are bound to Windows anyway, and therefore somehow referencing .netframework will not limit your application further.

@mrbean-bremen
Copy link
Collaborator

mrbean-bremen commented Feb 9, 2022

I was actually wrong, it's System.Drawing.Common what I was referring to, not System.Drawing, though that namespace is also effected.

@MrBean2016
Copy link

I had the same problem so I pulled down the repo, created a .Net-project file (Net 6.0), added the source-files, added System.Drawing.Common 6.0 as a Nuget-packet and it seems to work without any dependencies to .Net Framework.

@gofal gofal added infrastructure and removed new labels Jun 25, 2022
gofal added a commit that referenced this issue Jul 12, 2023
…on to net462 (#1318) (#1610)

Co-authored-by: Tim Cooke <tcooke@greateyecare.com>
Co-authored-by: Reinhard Gruber <gofal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants