Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lossy compression ratio tag is overwritten after compression #1400

Closed
BobSter3000 opened this issue Jun 14, 2022 · 0 comments · Fixed by #1401
Closed

Lossy compression ratio tag is overwritten after compression #1400

BobSter3000 opened this issue Jun 14, 2022 · 0 comments · Fixed by #1401
Labels

Comments

@BobSter3000
Copy link
Contributor

Describe the bug
Lossy Compression Ratio Tag, (0028,2112) is a multi-value tag if successive lossy compression steps have been applied. Currently fo-dicom overwrites the tag instead of adding another value to the tag.

To Reproduce
Perform lossy compression on an image that already has the lossy compression ratio tag with a value set and review the lossy compression tag. Note only one value is present.

Expected behavior
The original values will have an additional value applied.

Screenshots or test DICOM files
If applicable, add screenshots or test DICOM files to help explain your problem.

Environment
Fellow Oak DICOM version: 5.0.3
OS: Windows 10 x64
Platform: .NET 6.0

I have a potential fix and will submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants