Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetDateTimeOffset extension makes a false assumption of default time zone #1511

Closed
bjorn-malmo opened this issue Feb 2, 2023 · 0 comments · Fixed by #1512
Closed

GetDateTimeOffset extension makes a false assumption of default time zone #1511

bjorn-malmo opened this issue Feb 2, 2023 · 0 comments · Fixed by #1512
Labels
bug

Comments

@bjorn-malmo
Copy link
Contributor

Describe the bug
The GetDateTimeOffset extension uses the current date's offset when no timezone info is present in the dataset. This is not correct when the date in question is in a different day-light savings period.

Environment
Fellow Oak DICOM version: 5.0.3
@bjorn-malmo bjorn-malmo added the new label Feb 2, 2023
bjorn-malmo added a commit to bjorn-malmo/fo-dicom that referenced this issue Feb 2, 2023
@bjorn-malmo
fo-dicom#1511 Fixed GetDateTimeOffset extension using local timezone …
c6b7c36 
…in the wrong way
@bjorn-malmo bjorn-malmo mentioned this issue Feb 2, 2023
Merged
1 task
@mrbean-bremen mrbean-bremen added bug and removed new labels Feb 2, 2023
mrbean-bremen pushed a commit that referenced this issue Feb 8, 2023
@bjorn-malmo
Fix GetDateTimeOffset extension with daylight savings (#1512)
1f5ef32 
* fixes #1511 - Fixed GetDateTimeOffset extension using local timezone in the wrong way
* Added a test for using the top level dataset in GetDateTimeOffset extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1511 Fixed GetDateTimeOffset extension with daylight savings bjorn-malmo/fo-dicom
2 participants
@mrbean-bremen @bjorn-malmo