Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IO.ByteConverter.ToArray() instead of ByteBufferEnumerator.Create<T>().ToArray() where applicable #72

Closed
anders9ustafsson opened this issue Aug 12, 2015 · 0 comments
Closed

Use IO.ByteConverter.ToArray() instead of ByteBufferEnumerator.Create<T>().ToArray() where applicable #72

anders9ustafsson opened this issue Aug 12, 2015 · 0 comments
Assignees
@anders9ustafsson
Labels
enhancement
Milestone
2.0.0

Comments

@anders9ustafsson
Copy link
Contributor

As far as I can tell, the rationale for PR #11 is still valid, although some of the instances where ByteBufferEnumerator.Create<T>().ToArray() have since then been removed. I therefore suggest that we refactor the code where ByteBufferEnumerator.Create<T>().ToArray() is still in use to enhance the performance of the library.
@anders9ustafsson anders9ustafsson self-assigned this Aug 12, 2015
@anders9ustafsson anders9ustafsson added this to the 2.0.0 milestone Aug 12, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Aug 13, 2015
@anders9ustafsson
Added tests to verify DicomOtherByte refactoring. Issue fo-dicom#72
2698f57
anders9ustafsson added a commit that referenced this issue Aug 13, 2015
@anders9ustafsson
Merge pull request #73 from anders9ustafsson/GH-72
3a32d97 
Replace ByteBufferEnumerator calls with ByteConverter. Connected to #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anders9ustafsson anders9ustafsson

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@anders9ustafsson