Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing properties to IDicomClient #1171

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

gasupidupi
Copy link
Contributor

@gasupidupi gasupidupi commented Apr 16, 2021

Checklist

  • The pull request branch is in sync with latest commit on the fo-dicom/development branch
  • I have updated API documentation
  • I have included unit tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

  • Added the Host, Port, UseTls, CallingAe, CalledAe and IsSendRequired properties to the IDicomClient interface.

@gasupidupi
Copy link
Contributor Author

Hi, this is my first PR to this project so please let me know if I'm doing something wrong. Anyways keep up the good work, it's an amazing library!

@gofal
Copy link
Contributor

gofal commented Apr 17, 2021

Thanks, this is fine.
You added the properties in version 4, which is mainly maintained to fix bugs. The go-forward solution is version 5 (fo-dicom.full.sln). Could you please add the changes in this version, too. Otherwise you will have an issue when upgrading to version 5.

@gasupidupi
Copy link
Contributor Author

gasupidupi commented Apr 17, 2021

Sure, did I add it at the right spot?

@gofal gofal merged commit 023e7d8 into fo-dicom:development Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants