Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to configure TCP buffer sizes #1564

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Conversation

amoerie
Copy link
Collaborator

@amoerie amoerie commented May 11, 2023

I'm currently working on consolidating our custom fo-dicom fork changes. This is a small part of that. :-)

Checklist

  • The pull request branch is in sync with latest commit on the fo-dicom/development branch
  • I have updated API documentation
  • I have included unit tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

  • Add ReceiveBufferSize and SendBufferSize options in (two) places where we create a TcpClient

I don't have a clue how this can be unit tested. :-)

@amoerie amoerie marked this pull request as ready for review May 11, 2023 14:20
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (58efbad) 79.99% compared to head (abb9728) 80.04%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1564      +/-   ##
===============================================
+ Coverage        79.99%   80.04%   +0.05%     
===============================================
  Files              266      266              
  Lines            24848    24857       +9     
===============================================
+ Hits             19877    19898      +21     
+ Misses            4971     4959      -12     
Impacted Files Coverage Δ
FO-DICOM.Core/Network/Client/DicomClient.cs 96.96% <ø> (ø)
FO-DICOM.Core/Network/DesktopNetworkListener.cs 87.50% <ø> (ø)
FO-DICOM.Core/Network/DicomServer.cs 92.77% <ø> (ø)
FO-DICOM.Core/Network/DesktopNetworkStream.cs 95.65% <100.00%> (+0.78%) ⬆️
FO-DICOM.Core/Network/DicomServiceOptions.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ChangeLog.md Outdated Show resolved Hide resolved
@gofal gofal merged commit 42b7687 into development Jul 12, 2023
5 checks passed
@gofal gofal deleted the tcp-buffer-sizes branch July 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants