Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaxClientsAllowed #1670

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Fix MaxClientsAllowed #1670

merged 4 commits into from
Dec 21, 2023

Conversation

amoerie
Copy link
Collaborator

@amoerie amoerie commented Oct 27, 2023

Fixes #1669 .

Checklist

  • The pull request branch is in sync with latest commit on the fo-dicom/development branch
  • I have updated API documentation
  • I have included unit tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

  • Use Semaphore.WaitAsync with timeout to avoid entering the Semaphore and causing MaxClientsAllowed to get stuck

@amoerie amoerie marked this pull request as ready for review October 27, 2023 12:52
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f6564f5) 76.40% compared to head (882d08a) 76.39%.

❗ Current head 882d08a differs from pull request most recent head fa89686. Consider uploading reports for the commit fa89686 to get more accurate results

Files Patch % Lines
FO-DICOM.Core/Network/DicomServer.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1670      +/-   ##
===============================================
- Coverage        76.40%   76.39%   -0.02%     
===============================================
  Files              274      274              
  Lines            25168    25153      -15     
  Branches          3008     3001       -7     
===============================================
- Hits             19230    19216      -14     
+ Misses            5017     5015       -2     
- Partials           921      922       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gofal gofal merged commit 041c1e7 into development Dec 21, 2023
4 checks passed
@gofal gofal deleted the GH1669 branch December 21, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants