Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add proxy #8

Closed
wants to merge 1 commit into from
Closed

Conversation

mar-heaven
Copy link
Contributor

set proxy from env

@foamzou
Copy link
Owner

foamzou commented Aug 25, 2022

Thanks the PR. Could you help to add the proxy for all the request? Such as the function createClient().
Your PR would be serve when the default environment proxy was set.

And I have a idea that media-get can provide the options to let the user set diffrent proxy per website/source.
For example. I would like to set the a proxy for youtube and set the b proxy for douyin.
I need to make a friendly options design for the feature. Both of the following is need.

  1. default config file for media-get. Place to /$HOME/.media-get.json
  2. cmd options

Not just for the user, after the feature launched, the CI would be run well 😄

@mar-heaven
Copy link
Contributor Author

Good idea! i'm going to enhance the feature.

@foamzou
Copy link
Owner

foamzou commented Jan 18, 2023

The feature has been implemented by #12

Thx for your working anyway, bro.

Closed the PR.

@foamzou foamzou closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants