Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stats #1119

Merged
merged 4 commits into from
Mar 20, 2022
Merged

Adding stats #1119

merged 4 commits into from
Mar 20, 2022

Conversation

AndyatFocallocal
Copy link
Member

My commenting out doesn't seem to work.

@Marvelxy I noticed you used a different method which wasn't familiar to me. Would you help me understand why the commenting out doesn't work in this PR please

@AndyatFocallocal
Copy link
Member Author

I moved your commenting out into the 1st 7 lines to make it easy to find

@Marvelxy
Copy link
Member

Douglas Crockford removed the ability to add comments to JSON files:

https://en.wikipedia.org/wiki/JSON#:~:text=Comments%20were%20intentionally%20excluded%20from,which%20would%20have%20destroyed%20interoperability.%22

image

The only way to add comment is to stick to a pattern, something similar to what I did.

Copy link
Member

@Marvelxy Marvelxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can transform your comment into something like the image properties I added.

Copy link
Member

@Marvelxy Marvelxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@AndyatFocallocal
Copy link
Member Author

looks good to me.

...really?!

@AndyatFocallocal AndyatFocallocal merged commit ecd242d into master Mar 20, 2022
@AndyatFocallocal AndyatFocallocal deleted the AndyatFocallocal-with-stats branch October 15, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants