Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use only POJOs for Jollyday configuratoin to have zero dependencies on Jackson/JAXB or any other xml parsing libraries #452

Open
gandulf opened this issue Feb 2, 2024 · 0 comments
Labels
status: new Initial state for every issue / pull request

Comments

@gandulf
Copy link
Contributor

gandulf commented Feb 2, 2024

More information

Hi,
I plan to use jollyday in a quarkus graalvm microservice projects where i try to keep additional dependencies especially regarding jackson/jaxb etc, to a minimum. Therefore I made a jollyday implementation that only uses plain old java objects for configuration.

I know that this means that a change/reconfiguration of the holiday data is no longer possible but in the past years I've been using it I never needed that flexibility since the holiday definitions are rather global and consistent.

Disclaimer: At the moment the POJOs are generated based on the xml files inside a pseudo test class "JavaGeneratorTest" that takes the JacksonConfiguration Classes and creates the POJOs SourceCode using ugly String Writer logic. Not my proudest part of java code, but it works is only needed in case the configuration changes and needs to be recreated.

see PR #451 for current implementation

@gandulf gandulf added the status: new Initial state for every issue / pull request label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: new Initial state for every issue / pull request
Projects
None yet
Development

No branches or pull requests

1 participant