Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dutch holiday naming #433

Merged

Conversation

janjongerden
Copy link

To match the commonly used Dutch naming, updated these days:

  • 'king's day' -> 'Koningsdag'
  • replaced 'STEPHENS' with 'SECOND_CHRISTMAS_DAY', as St.Stephens is not celebrated
  • changed Easter, Pentecost and Christmas to use first/second day style ('eerste'/'tweede' in Dutch)

After this update, the list of holidays in the Netherlands, in Dutch will be:

Nieuwjaar
Dag van de koning --> Koningsdag
Bevrijdingsdag
Goede vrijdag
Pasen --> Eerste paasdag
Paasmaandag --> Tweede paasdag
Hemelvaartsdag
Pinksteren --> Eerste pinksterdag
Pinkstermaandag --> Tweede pinksterdag
Kerstmis --> Eerste kerstdag
St.Stephen's Dag --> Tweede kerstdag

For reference, two pages on Dutch holidays: Dutch government site and the wikipedia page.

@derTobsch derTobsch added this to the 0.24.0 milestone Jan 16, 2024
To match the commonly used Dutch naming, updated these days:
- 'king's day' -> 'Koningsdag'
- replaced 'STEPHENS' with 'SECOND_CHRISTMAS_DAY', as St.Stephens is
  not celebrated
- changed Easter, Pentecost and Christmas to use first/second day style
  ('eerste'/'tweede' in Dutch)
@derTobsch derTobsch merged commit 435cb1e into focus-shift:main Jan 17, 2024
9 checks passed
@janjongerden
Copy link
Author

Thank you for the quick review and merge @derTobsch 🎉 And for this handy library of course 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants