Check holidays 02/2024 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
XSpielinbox
force-pushed
the
check_holidays
branch
from
7e2c86b
to
a98b0f6
Compare
derTobsch
added
country: cayman islands
country: mauritius
country: hong kong
country: singapore
country: virgin islands (british)
country: bermuda
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃巵 check that the past holidays (2023 and 2024) and the future holidays (as far as known at the moment) are correct for the countries Hong Kong, Singapore, Mauritius, Bermuda, Cayman Islands and Virgin Islands (British)
馃悶 Discovery Day was replaced by Emancipation Day in the Cayman Islands
馃悶 An unconfirmed date for King's Birthday in the Cayman Islands was announced
馃巵 add sources to the holiday definitions and test cases of above countries/territories (at least that I could easily find again and make sense to add)
For the Bahamas, unfortunately, I still cannot find any information on when they have public holidays. Therefore I was unable to check the dates.