Fix Bavaria #269 #483
Open
Fix Bavaria #269 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐞 closes #269
@derTobsch would you be ok with leaving Augsburg's special holiday, but moving assumption day up one level to Bavaria as it is applicable to the majority of cities and not only the few that currently exist as more specific cases?
As these non ISO 3166 cities then would have no holidays I have removed them, as I would see ADR 001 as not applicable as there are just to many cities for which I don't see the value to have empty configurations for them.
But if you wish, I could also leave them empty and add empty configurations for other major Bavarian cities.