Update for React 16 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #15 |
| "react": "^15.5.0", | ||
| "react-dom": "^15.5.0" | ||
| "react": "^16.0.0", | ||
| "react-dom": "^16.0.0" | ||
| }, |
There was a problem hiding this comment.
Can we add react and react-dom peerDependencies of 0.14.x || ^15.0.0 || ^16.0.0?
There was a problem hiding this comment.
Thanks @shiawuen and @emilyrohrbough!
One question to sort out, then we can merge and release.
| @@ -68,6 +68,9 @@ | |||
| ] | |||
| }, | |||
| "jest": { | |||
| "setupFiles": [ | |||
| "<rootDir>/test/__mocks__/requestAnimationFrame.js" | |||
There was a problem hiding this comment.
@shiawuen Why was it necessary to add this?
There was a problem hiding this comment.
There was a problem hiding this comment.
React also depends on requestAnimationFrame (even in test environments).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi submitting this to make it work with React 16