Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage badge to the README #260

Closed
thawkin3 opened this issue Mar 4, 2021 · 5 comments · Fixed by #261
Closed

Add code coverage badge to the README #260

thawkin3 opened this issue Mar 4, 2021 · 5 comments · Fixed by #261

Comments

@thawkin3
Copy link
Contributor

thawkin3 commented Mar 4, 2021

Now that the test suite is converted over to use Jest and DOM Testing Library, what do you think about adding a code coverage badge to the README to show off the code coverage?

I see in the focus-trap-react repo we used Codecov along with GitHub Actions for the CI. In this tabbable repo it's also using GitHub Actions for the CI, so I assume we can generate the code coverage report there and then feed the results to Codecov, right? Or maybe even generate the badge without using Codecov if that's not something you want to do, and we could just use GitHub Actions directly?

Thoughts?

@stefcameron
Copy link
Member

@thawkin3 Hey, yes, I see no reason why we couldn't add a Codecov badge to this repo now. We should be able to set it up the same way as in focus-trap-react. Both repos are setup the same way with GH actions, etc. Just need to invite the Codecov bot to this repo and connect to it with the codecov library.

@stefcameron
Copy link
Member

Codecov bot now has access to this repo. Just need to start feeding it data. 😄

@stefcameron
Copy link
Member

You're welcome to do the rest if you want. That will just require a small PR. Otherwise, LMK so we don't double-up.

@thawkin3
Copy link
Contributor Author

thawkin3 commented Mar 4, 2021

Thanks! I'm happy to knock this out. I'll have a PR up hopefully in the next day or two to get this set up.

@thawkin3
Copy link
Contributor Author

thawkin3 commented Mar 4, 2021

Here ya go! #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants