187-Created common opendata conn class and implemented crime download #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2017
Closed
|
I merged this code into a master 'combined-api-prs' branch with the other related branches and made a new pull request for the merged branch. RE BOM - the current code should now be ready to handle that thanks to Meg and #242! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also set the base for #274, impacts #198, #194, and other issues for data from opendata.
Sample usage -
python get_api_data.py opendata get_crime --output ../../data/raw/crime/2017.csv --params "year:2017"Please note csv files from opendata come with BOM, so we might still need to test with any cleanup logic that was written.