Upgrade to JuMP 0.19 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianfiske
commented
Jun 20, 2019
|
Please have a look @juliebuard. I couldn't add you as an official reviewer. |
|
nice clean up of files and especially operator.jl! |
|
A note for reviewers: this new version is based on https://github.com/JuliaOpt/JuMP.jl/blob/master/test/JuMPExtension.jl, reviewing that first will help make sense of this PR. |
juliebuard
reviewed
Jun 24, 2019
juliebuard
reviewed
Jun 24, 2019
juliebuard
reviewed
Jun 25, 2019
juliebuard
reviewed
Jun 25, 2019
|
nice overall improvements @ianfiske thanks to those API! " lu et approuvé" ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul upgrade to JuMP 0.19 and MathOptInterface following the advice of @blegat in https://discourse.julialang.org/t/advice-about-refactoring-linearfractional-jl-for-jump-0-19-and-julia-0-7/12966/2.
This resulted in a dramatic reduction in code complexity because of the new
AbstractVariableRefapi which allowed all of those beautiful operator and affine-expression methods to work out-of-the-box.Note however, that I got rid of the
@numeratorand@denominatormacros since they required a bunch of parsing overhead that I'd rather eliminate. The less-magical function version just takes a couple ofGenericAffExprfor the numerator and denominator arguments toset_objective.