Extra slash added for env_config['cp_url']

[gmhenderson]

Hello,

I just noticed that the $env_config['cp_url'] variables gets an extra slash. This is in config.master.php, around like 105. See:

$env_config['base_url']            = $base_url . '/';
$env_config['site_url']            = $env_config['base_url'];
$env_config['cp_url']              = $env_config['base_url'] . '/admin.php';

It's safe to remove the slash that appears before admin.php, yes?

[erikreagan]

Yes, that's a good catch. We'll tweak that for the future. Thank you!

Erik

[agemmell]

Downloaded ee-master-config today - looks good! I notice this bug hasn't been fixed in the repo though. Easy enough to change manually myself but just wanted to bump this issue!

[erikreagan]

Ah, thanks for the catch @agemmell. I see there's a pull request about this so we'll merge it in now.

Erik

[danystad]

Hello, I just came across the double slash issue today, when troubleshooting two EE add-ons.

I removed the trailing slash manually and it works fine now. Just wanted to let you know as it still in the repo.

Great setup by the way.

Dany