Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report defaults (masters) #17

Closed
focustense opened this issue Jun 22, 2021 · 2 comments
Closed

Report defaults (masters) #17

focustense opened this issue Jun 22, 2021 · 2 comments
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Milestone

Comments

@focustense
Copy link
Owner

This has some overlap with #5 but in a different context. Since building the NPC mod is an expensive process, it will be helpful to inform people which plugins are going to end up as masters before they actually start the build. This could maybe be shown on the build confirmation screen, just before clicking the "Build" button, since that screen has a good amount of empty space already.

Integrating with #5 when implemented would also be a good idea - i.e. if a suspicious master is present, they could double-click on it and be taken to a filtered Profile view showing every NPC that includes it as the master (default).

I think this would be the most straightforward, lowest-effort (for users) method of fixing any mistakes that EasyNPC made in its initial scan, or stray edits during the profile build.

@focustense focustense added enhancement New feature or request easynpc Issues/requests relating the EasyNPC app labels Jun 22, 2021
@focustense
Copy link
Owner Author

Not sure if I'll tackle this for beta or for 1.0. Now that I've considered the idea, it seems pretty important, but need to be careful of scope creep.

@focustense
Copy link
Owner Author

I have an 80% complete implementation of this that displays the masters after the build warnings (same screen where you enter the output mod name).

This pre-build UI needs to start getting reworked as the pre-build report gets more sophisticated, but for now this should be just good enough in terms of display.

What it still needs before I'll release it is a feature where double-clicking will go to the Profile page and enable the selected plugin as a filter, to make it very easy to find and fix all the related NPCs. Also, since this may turn on a filter for users who have never used the filters before, and not understand where the rest of the NPCs went, the Profile screen will need to prominently highlight the fact that a filter is active, i.e. by coloring or maybe even animating the filter button.

I'm thinking, animate it for 15-30 seconds, and then keep a color mutation on it, so that it can always be seen that a filter is active, but the animation doesn't keep distracting people. Also, the animation shouldn't trigger if the filter is turned on from the filter box.

focustense added a commit that referenced this issue Jul 24, 2021
This will show all of the masters that the merge will take on, as well as flag any that "look like" overhauls (logic borrowed from the Standard Rule Set).

Ref #17 (not complete).
focustense added a commit that referenced this issue Jul 24, 2021
Message bus will be a general concept for components to communicate in a decentralized way without having to plumb event handlers and such through multiple layers. Page navigation already has to do this, so it has been converted, and a similar method will be needed for navigating to a filtered profile view (#17).
focustense added a commit that referenced this issue Jul 24, 2021
Navigates to the profile page, using default filters plus an added filter for the default plugin, to help locate these records quickly.

Progresses #17 (still need highlighting).
focustense added a commit that referenced this issue Jul 24, 2021
This is a hack to deal with a flow that has gotten a little weird. If the user has previously dismissed warnings (i.e. they're at "ready to build") *and* has subsequently changed the profile, then the build state will reset so that checking is recommended again.

Especially important for dealing with unwanted masters, because otherwise they'd come back to the build screen and it would look like the master is still required, even if it no longer is.

Fixes #17 (more).
focustense added a commit that referenced this issue Aug 1, 2021
The component will be used for top level info in new reports e.g. pre- and post-build reports (#37, #17, #51, #61, #78, etc.)

This is especially for the pre-build report, for which the flow is becoming too unwieldy and needs to be redesigned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant