Skip to content

Commit

Permalink
Code review remarks
Browse files Browse the repository at this point in the history
- remove unused include
- document usage of different std lib on mac
- remove trailing semicolon
  • Loading branch information
TheJasperV committed Jun 19, 2019
1 parent 7fae8c6 commit 9b816a3
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions setup.py
Expand Up @@ -26,7 +26,7 @@
import distutils.ccompiler
from distutils.dep_util import newer
from distutils.command.install import install as _install
import sys, glob, os, fnmatch, platform
import sys, glob, os, fnmatch
import subprocess
import shlex

Expand Down Expand Up @@ -463,8 +463,9 @@ def run(self):
else:
vidInclude = ['.']

extra_compile_args_pitch = [];
extra_link_args_pitch = [];
extra_compile_args_pitch = []
extra_link_args_pitch = []
# As of mac os version 10.13.6 (high sierra), xcode 10 is supported. Xcode 10 requires the use of the libc++ standard library.
if os.uname()[0] == "Darwin" and pkg_resources.parse_version(os.uname()[2]) >= pkg_resources.parse_version("17.7.0"):
print("success")
extra_compile_args_pitch.append("-stdlib=libc++")
Expand Down

0 comments on commit 9b816a3

Please sign in to comment.