how to support additional aws regions, e.g. cn-north-1

[dwu-pivotal]

how to support additional aws regions, e.g. cn-north-1, thx

[geemus]

Usually it is pretty straightforward, we just add it to the list of expected values for initialization. But if I remember correctly there are some particulars around cn-north-1 that make this more complicated.

@lanej @fcheung do either of you remember the specifics around the cn regions that made them more difficult and/or am I misremembering?

[lanej]

@geemus @fcheung if i remember correctly, not everyone has access to it. So it's possible to give users a false expectation of success.

Validation of region is also disparate across all services. Might be worth cleaning that up too. Maybe create some mechanism for enabling other regions that only certain users have access to ?

[fcheung]

For china, as for other regions, signature v4 is required, at the time that code didn't exist so it would have been a big effort (that in the end got done with the frankfurt region)

The china one is a bit special - you have to have a separate account (apparently it's still in limited preview) so there may be no-one in a position to test it. To be honest I'd be fine with fog just validating that it's a valid region at all, and if you try and use a region that you don't have access to you'll find out soon enough.

[geemus]

I'd also lean toward just letting people specify (and get an error), seems simplest and probably good-enough. If somebody would like to add it to the list of acceptable regions in a PR I think we will probably be good to go.

[github-actions]

This issue has been marked inactive and will be closed if no further activity occurs.

[geemus]

Appears to have been closed by #169