Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove digitalocean version 2 and bump version #195

Merged
merged 2 commits into from Aug 4, 2016

Conversation

h0lyalg0rithm
Copy link
Member

@geemus I have removed version2 of digitalocean to clean up the fog-digitalocean gem. fog/fog-digitalocean#9 has the changes for in the fog-digitalocean gem

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 72.804% when pulling 3a510d4 on h0lyalg0rithm:remove_digital_ocean_v2 into 5c3d2fb on fog:master.

@@ -1,5 +1,5 @@
module Fog
module Core
VERSION = "1.42.0"
VERSION = "1.42.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this change please?
Is better to leave the bump to the moment of the release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if you let us know when this is removed we can get the rest merged, thanks!

@h0lyalg0rithm
Copy link
Member Author

Thanks @geemus && @plribeiro3000 I have removed the version bump.

@coveralls
Copy link

coveralls commented Aug 4, 2016

Coverage Status

Coverage increased (+0.4%) to 72.804% when pulling 6a377b9 on h0lyalg0rithm:remove_digital_ocean_v2 into 5c3d2fb on fog:master.

@geemus geemus merged commit ec8d3a5 into fog:master Aug 4, 2016
@geemus
Copy link
Member

geemus commented Aug 4, 2016

Thanks!

@h0lyalg0rithm h0lyalg0rithm deleted the remove_digital_ocean_v2 branch August 4, 2016 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants