Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency to google-api-ruby >= 0.27.3 to support custom hostname #479

Closed
eLvErDe opened this issue Dec 11, 2019 · 2 comments
Closed

Comments

@eLvErDe
Copy link

eLvErDe commented Dec 11, 2019

Hello,

Could you please consider making 0.27.3 the minimum required version ? It's the first version supporting "hostname" parameter to set a custom hostname and I think it's an important feature.

https://github.com/googleapis/google-api-ruby-client/blob/0.27.3/generated/google/apis/compute_v1/classes.rb#L7159

Also releasing a GEM would be great, so Foreman can update its dependencies and provide "hostname" integration as well.

Thanks in advance,

Adam.

@Temikus
Copy link
Member

Temikus commented Feb 20, 2020

@eLvErDe Just updated the gemspec since we needed to bump for Stackdriver anyway: https://github.com/fog/fog-google/blob/master/fog-google.gemspec#L29

I am planning to roll up a release soon-ish (within the next month). I have been away for a while due to medical reasons so it'll take me a bit to fixup everything.

I'll resolve this but feel free to reopen if I missed anything.

@Temikus Temikus closed this as completed Feb 20, 2020
@eLvErDe
Copy link
Author

eLvErDe commented Feb 20, 2020

Great thanks a lot.
Hope you'll recover just fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants