Allow for newer versions of kubeclient #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @masayag |
shiramax
approved these changes
Apr 21, 2020
|
Thanks @shiramax ! |
|
@shiramax @masayag if you don't mind cutting a release, I was able to successfully run the kubevirt, kubernetes, and openshift specs with kubeclient 4.6 (ManageIQ/manageiq-cross_repo-tests#111) |
|
Hey @shiramax @masayag we'd like to move to at least kubeclient v4.5 to allow for use of watches with ruby 2.7, see ManageIQ/kubeclient#442 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure if you'd prefer bumping kubeclient to the current version (4.6.0) or opening up the fog-kubevirt gemspec to allow for the bundling program to dictate the kubeclient version they would like. I'll leave that up to the maintainers