Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation not supported: cannot change keymap setting on vnc graphics #42

Closed
santachago opened this issue Jul 4, 2017 · 13 comments · Fixed by #43
Closed

Operation not supported: cannot change keymap setting on vnc graphics #42

santachago opened this issue Jul 4, 2017 · 13 comments · Fixed by #43

Comments

@santachago
Copy link

santachago commented Jul 4, 2017

Looks like libvirt doesnt support to set keymap when using vnc.

 | Libvirt::Error: Call to virDomainUpdateDeviceFlags failed: Operation not supported: cannot change keymap setting on vnc graphics
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/requests/compute/update_display.rb:21:in `update_device'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/requests/compute/update_display.rb:21:in `update_display'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/models/compute/server.rb:218:in `update_display'
@mmoll
Copy link
Contributor

mmoll commented Jul 18, 2017

@santachago could you check if reverting #30 fixes that issue?

@mmoll
Copy link
Contributor

mmoll commented Jul 26, 2017

@tbrisker looking at #30 I don't get the whole current situation, as that was also about vnc

@tbrisker
Copy link
Contributor

@mmoll IIRC #30 in my case was caused by having a non-auto setting for the keymap, which was failing because fog-libvirt wasn't passing a keymap and libvirt was defaulting to auto (which was different then the existing setting and thus failed to change it). That being said, I think there may be a better solution then this. Sadly I don't have the setup I had previously to try and fix it at the moment.

@santachago
Copy link
Author

If i remove line number 16 -> display[:keymap] = options[:keymap] || xml_elements(domain.xml_desc, "graphics", "keymap")

vms with no keymap defined on the config work fine. If a vm has a value defined it fails with the same error.

@mmoll
Copy link
Contributor

mmoll commented Aug 5, 2017

possible fix in #43

@plribeiro3000
Copy link
Member

@santachago @tbrisker @mmoll Could you guys please test if master fixed the issue please?

@mmoll
Copy link
Contributor

mmoll commented Aug 20, 2017

I can only say it fixed it for me (which is expected as I wrote the patch ;)).

@mmoll
Copy link
Contributor

mmoll commented Aug 20, 2017

@santachago any update here? ☝️

@plribeiro3000
Copy link
Member

@mmoll Thanks for the feeback. 👍

@hesperaux
Copy link

Hello all,

I just updated to foreman 1.15.3. Running debian 8.9 on my foreman host, and the same on my compute hosts. I ran into this issue after updating.

I've manually patched /usr/share/foreman/vendor/ruby/2.1.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/requests/compute/update_display.rb according to https://github.com/fog/fog-libvirt/pull/43/files on my foreman install and this fixed the issue for me.

Thanks for the patch!

@mmoll
Copy link
Contributor

mmoll commented Aug 24, 2017

I guess a 0.4.1 release would be nice then...

@plribeiro3000
Copy link
Member

Cuting a release now. =)

@plribeiro3000
Copy link
Member

Released as 0.4.1. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants