Allow update_display on VMs with non-auto keymap #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strzibny Could you please take a look at this PR? |
If the vnc keymap has been changed from auto to, for example, en-us, calling update_display will fail with a "Call to virDomainUpdateDeviceFlags failed: internal error cannot change keymap setting on vnc graphics" error. This commit changes it so that if no keymap has been passed explicitly in the options we will use the keymap that is currently used.
|
What's the status here? BTW, there are quite some people from @theforeman using fog-libvirt actively, if new maintainers need to be found... |
|
This looks good to me, I will merge. @mmoll it would be awesome if some folks from Foreman wants to co-maintain :) (anyone can shoot me an e-mail). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the vnc keymap has been changed from auto to, for example, en-us,
calling update_display will fail with a "Call to
virDomainUpdateDeviceFlags failed: internal error cannot change keymap
setting on vnc graphics" error. This commit changes it so that if no
keymap has been passed explicitly in the options we will use the keymap
that is currently used.