Fix disk type for block devices on QEMU >= 6.0 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since QEMU version 6.0 [1], you can't use the file block driver with block devices. It tries to detect block devices by looking at the file path. [1] https://wiki.qemu.org/ChangeLog/6.0#Incompatible_changes
ekohl
force-pushed
the
fix-disk-type-for-block-devs-on-qemu-6
branch
from
d95a011
to
521cf3f
Compare
|
@ekohl I will look into it, thanks for pushing this issue forward! Is there an easy way to build this gem and install it into Foreman or should I just apply the patch manually and test it? |
|
Ok, seems like the vendored fog-libvirt gem in Foreman is on version 0.11.0, which is quite different from the current master branch (using XML builder instead of an ERB template), so applying this patch manually won't work. |
|
The patch looks good. I've tested it on our Foreman server:
In those cases, it produced a valid XML description and the VMs started without problems. |
|
Thanks for confirming @rwf14f! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since QEMU version 6.0, you can't use the file block driver with block devices. It tries to detect block devices by looking at the file path.
This builds on #116, but I don't have the capacity to test this myself right now.