Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 support #522

Open
maciejpankanin opened this issue Mar 10, 2022 · 4 comments · May be fixed by #527
Open

Ruby 3.0 support #522

maciejpankanin opened this issue Mar 10, 2022 · 4 comments · May be fixed by #527

Comments

@maciejpankanin
Copy link

Recently I bumped ruby to 3.0 and received this error:

NoMethodError: undefined method `encode' for URI:Module
  from fog-openstack (1.0.11) lib/fog/openstack/storage/requests/delete_multiple_objects.rb:48:in `block in delete_multiple_objects'
  from fog-openstack (1.0.11) lib/fog/openstack/storage/requests/delete_multiple_objects.rb:46:in `map'
  from fog-openstack (1.0.11) lib/fog/openstack/storage/requests/delete_multiple_objects.rb:46:in `delete_multiple_objects'
  from activestorage-openstack (1.5.2) lib/active_storage/service/open_stack_service.rb:78:in `block in delete_prefixed'
  [...]

URI.escape (URI.encode is an alias) was already obsolete in ruby 2.7 and removed in 3.0.

Are there chances this will be fixed?

@chaadow
Copy link

chaadow commented Oct 8, 2022

@maciejpankanin i'll make a temporary workaround on https://github.com/chaadow/activestorage-openstack

@chaadow chaadow linked a pull request Oct 8, 2022 that will close this issue
@chaadow
Copy link

chaadow commented Oct 8, 2022

@maciejpankanin released in v1.6.0 and opened a PR #527. So until they merge it, you can try this workaround.

image

@talentohq
Copy link

@dhague, @Ladas, @seanhandley, @mdarby @jjasghar.

Any chances of merging this PR and support ruby 3.0?

Thank you!

@geemus
Copy link
Member

geemus commented May 13, 2024

@talentohq I'd be happy to discuss and try to work on a fix, but I'm not sure if we can use that PR as is or if we'll need to do some more work. I've added a comment there and would welcome insights (as I'm not an active user of openstack myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants