Merge new master branch to old fix-rubocop one #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace no longer used `Style/TrailingCommaInLiteral` cop with `Style/TrailingCommaInArrayLiteral` and `Style/TrailingCommaInHashLiteral`
Remove redundant slash in get_server_volumes.rb file
Remove redundant slash
Storage: Set cache-control header for a file
Signed-off-by: Melvin Hillsman <mrhillsman@gmail.com>
Add configuration for OpenLab
Signed-off-by: Melvin Hillsman <mrhillsman@gmail.com> Depends-On: fog#392
Add playbooks directory with job definitions
Use autoload with default gem path
Docs: fix an anchor link
Replaces Openstack with OpenStack where needed
No comments at end of blocks
Bump ruby, fog-core versions; Each not each_pair
Rake: reduce double definition; Default launch
Jobs are failing due to timeout retrieving keys Signed-off-by: Melvin Hillsman <mrhillsman@gmail.com>
Add additional key servers and keys
Tests: replace skip by conditional for fog-mocking
Moves autoload to allow reopening
…meter Add multiattach parameter to volume creation
Created explicit mock and real files for volume v1 and v2
Allow custom filename through Content-Disposition header
Recheck token expiration and re authenticate
|
OK, there is still remaining cops offended (10 remaining). But They are much touchy. I don't know when I'll be able to do then and if we can fix them. |
|
@ShamoX, that sounds good meanwhile I believe you have to start from latest commit because your PR is containing lots of already committed ones. Thanks |
|
Hello, Should we merge this and start working on ruby 2.7 and 3.x support (as asked by #522 ) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.