Shindo to minitest - Step 3 #123
Conversation
|
|
||
| describe "Fog::Openstack[:planning] | Planning role requests" do | ||
| before do | ||
| openstack = Fog::Identity[:openstack] |
There was a problem hiding this comment.
Useless assignment to variable - openstack.
|
Changes Unknown when pulling b7eeec8 on gildub:shindo_to_minitest-step_3 into * on fog:master*. |
|
|
||
| it "#patch_plan" do | ||
| parameters = Fog::Openstack[:planning].get_plan(@instance['uuid']). | ||
| body['parameters'][0..1] |
There was a problem hiding this comment.
Align body with Fog::Openstack[:planning].get_plan(@instance['uuid']). on line 52.
| end | ||
|
|
||
| after do | ||
| @user.ec2_credentials.each do |ec2_credential| |
There was a problem hiding this comment.
Pass &:destroy as an argument to each instead of a block.
|
Changes Unknown when pulling aaf7836 on gildub:shindo_to_minitest-step_3 into * on fog:master*. |
Migrates baremetal, introspection Also moves /test/openstack/* to /test (seems to be coming from the fog before the split)
|
|
||
| describe "failure" do | ||
| it "#save" do | ||
| proc { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
|
Changes Unknown when pulling 947c7e9 on gildub:shindo_to_minitest-step_3 into * on fog:master*. |
Migrates identity, image and planning Requires Pull Request "Shindo to Minitest - Step 2" to be merged first: #118
| "ipmi_password" => String, | ||
| "pxe_deploy_kernel" => String, | ||
| "ipmi_priv_level" => String, | ||
| "ipmi_bridging" => String |
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
|
Changes Unknown when pulling ab3b8d6 on gildub:shindo_to_minitest-step_3 into * on fog:master*. |
|
Changes Unknown when pulling 74e86ff on gildub:shindo_to_minitest-step_3 into * on fog:master*. |
|
This one is replaced by PR #129 which is independent from the other "Shindo to Minitests ones". |
Shindo to Minitest - 3rd set
Migrates identity, image and planning
Requires Pull Request "Shindo to Minitest - Step 2" to be merged first:
#118