Shindo to Minitest: image, planning #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 6e0ed48 on gildub:shindo_to_minitest-image-planning into * on fog:master*. |
| must_match_schema('images' => [@detailed_image_format]) | ||
| end | ||
|
|
||
| before do |
There was a problem hiding this comment.
I would move this in the beginning of describe block.
|
Apart from two |
| image_attributes[:location] = @test_iso.path | ||
| end | ||
|
|
||
| @instance = Fog::Image[:openstack].create_image(image_attributes).body |
There was a problem hiding this comment.
Inconsistent indentation detected.
|
Changes Unknown when pulling ad0a328 on gildub:shindo_to_minitest-image-planning into * on fog:master*. |
|
Changes Unknown when pulling f3cd981 on gildub:shindo_to_minitest-image-planning into * on fog:master*. |
Migrates image and planning from Shindo to Minitest Note: This is not using subfolder 'openstack' anymore
|
Changes Unknown when pulling 4c2e919 on gildub:shindo_to_minitest-image-planning into * on fog:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates image and planning from Shindo to Minitest
Note: This is not using subfolder 'openstack' anymore