Shindo to Minitest: nfv #133
Conversation
|
Changes Unknown when pulling 0a24e6f on gildub:shindo_to_minitest-nfv into * on fog:master*. |
| @@ -0,0 +1,27 @@ | |||
| def set_nfv_data | |||
There was a problem hiding this comment.
I do not like this method - what it does is that it creates a few instance variables, which is clear side effect and it is hidden from the user of this method.
I suppose that splitting this method into 3 functions with no creation of instance variables but just returning proper values would be more clean solution.
Or just return it from this function so it can be used as @nfv, @vnf_data, @auth = set_nfv_data which is only a little longer call and gives user of this function control over where are data stored without unseen side effects.
|
Other than inline comments LTGM. |
| "password" => "password" | ||
| } | ||
| } | ||
| return [@nfv, @vnfd_data, @auth] |
|
Changes Unknown when pulling 3676f42 on gildub:shindo_to_minitest-nfv into * on fog:master*. |
|
Changes Unknown when pulling f0afc94 on gildub:shindo_to_minitest-nfv into * on fog:master*. |
Migrates nfv from Shindo to Minitest Adds test/helpers/nfv_helper.rb to share common nvf data Note: This is not using subfolder 'openstack' anymore
|
Changes Unknown when pulling 76f5e03 on gildub:shindo_to_minitest-nfv into * on fog:master*. |
Migrates nfv from Shindo to Minitest
Adds test/helpers/nfv_helper.rb to share common nvf data
Note: This is not using subfolder 'openstack' anymore