Shindo to Minitest: compute #137
Conversation
|
|
||
| it "#get_volume_detail" do | ||
| @compute.get_volume_details(@volume_id) | ||
| .body.must_match_schema('volume' => @volume_format) |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
Align .body with .get_volume_details on line 38.
|
Changes Unknown when pulling 241e8e6 on gildub:shindo_to_minitest-compute into * on fog:master*. |
| 'config_drive' => String, | ||
| } | ||
|
|
||
| @reservation_format = { 'reservation_id' => String } |
There was a problem hiding this comment.
Space inside { detected.
Space inside } detected.
|
Changes Unknown when pulling e66edc7 on gildub:shindo_to_minitest-compute into * on fog:master*. |
|
Changes Unknown when pulling 326ebe3 on gildub:shindo_to_minitest-compute into * on fog:master*. |
| it "#resize_server(#{@server_id}, #{get_flavor_ref_resize})" do | ||
| compute.resize_server(@server_id, get_flavor_ref_resize).status.must_equal 202 | ||
| unless Fog.mocking? | ||
| compute.servers.get(@server_id).wait_for { self.state == 'VERIFY_RESIZE' } |
| group.name.must_equal 'my_group' | ||
| group.service.must_equal server.service | ||
| ensure | ||
| unless Fog.mocking? then |
There was a problem hiding this comment.
Do not use then for multi-line unless.
|
Changes Unknown when pulling 483e3db on gildub:shindo_to_minitest-compute into * on fog:master*. |
|
Changes Unknown when pulling 781af6b on gildub:shindo_to_minitest-compute into * on fog:master*. |
| @@ -33,4 +33,5 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'minitest' | |||
| spec.add_development_dependency 'vcr' | |||
| spec.add_development_dependency 'webmock', '~> 1.24.6' | |||
| spec.add_development_dependency 'pry-byebug' | |||
There was a problem hiding this comment.
Done. Although I'm thinking of adding it for good! :)
|
I am little concerned about big chunks of code in But I understand that this PR is about migrating tests so I am ok with that. We can clean it later. Thanks for this work. 👍 |
|
Changes Unknown when pulling 0d1735c on gildub:shindo_to_minitest-compute into * on fog:master*. |
Migrates compute models and requests Tests marked has`skip`(pending) using Minitest::Test::UNIT_TESTS_CLEAN - 1 x requests/compute/security_group_tests.rb - 1 x requests/compute/server_tests.rb Besides those two to be addressed the random tests failures have not occurred so far! Note: This is not using subfolder 'openstack' anymore
| :name => 'test server', | ||
| :flavor_ref => flavor, | ||
| :image_ref => image | ||
| ) |
There was a problem hiding this comment.
Indent ) the same as the start of the line where ( is.
|
Changes Unknown when pulling 48acd62 on gildub:shindo_to_minitest-compute into * on fog:master*. |
|
@petrblaho , I have addressed all issues, thanks for helping. |
Migrates compute models and requests
Tests marked has
skip(pending) using Minitest::Test::UNIT_TESTS_CLEANBesides later 2 to be addressed the random tests failures have not occurred so far!
Note: This is not using subfolder 'openstack' anymore