Token renewal fix #147
Merged
Token renewal fix #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling fc1241e on sapcc:token_renewal into * on fog:master*. |
fix token renewal not possible with token auth
|
Changes Unknown when pulling 245d565 on sapcc:token_renewal into * on fog:master*. |
|
LGTM - nice work. |
Ladas
added a commit
to Ladas/fog-openstack
that referenced
this pull request
Jul 19, 2016
Fix stck create action, getting not found on template, when stack has not been created yet. Brought by: fog#147
Merged
tzumainn
pushed a commit
to tzumainn/fog-openstack
that referenced
this pull request
Aug 10, 2016
Fix stck create action, getting not found on template, when stack has not been created yet. Brought by: fog#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial authentication happened with a token, there is no chance of renewing the token - so we should properly fail.
Following #146, where the fix is exercised on one service I take the chance to refactor the
requestmethod into thecoremodule.Please note the following details:
commonwas the role-modelset_api_path(newly introduced for metering service)self.not_found_class(fallback to compute. baremetal, orchestration and planning should introduce their own in the future I propose)parse_json, that needs to be removed later, in favor of the request param:raw_bodyI propose