add routes option to router update to add extra routes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,7 @@ def update_router(router_id, options = {}) | |||
| Fog::Logger.deprecation "Passing a model objects into options[:external_gateway_info] is deprecated. \ | |||
| Please pass external external gateway as follows options[:external_gateway_info] = { :network_id => NETWORK_ID }]" | |||
| router[:external_gateway_info] = { :network_id => egi.id } | |||
| else egi.is_a?(Hash) && egi[:network_id] | |||
| else egi.is_a?(Hash) | |||
There was a problem hiding this comment.
Odd else layout detected. Did you mean to use elsif?
and align mock
Carthaca
force-pushed
the
router_extra_routes
branch
from
ca28eee
to
3ae8fe6
Compare
|
Changes Unknown when pulling 3ae8fe6 on sapcc:router_extra_routes into * on fog:master*. |
|
Changes Unknown when pulling 3ae8fe6 on sapcc:router_extra_routes into * on fog:master*. |
|
Changes Unknown when pulling ca7793b on sapcc:router_extra_routes into * on fog:master*. |
|
resolved conflicts in #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and align mock