fallback for empty addresses #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the project.name was returned as tenant instead of the project itself (as in v2)
… setters make sense
… confusion with Volume API snapshots
… confusion with Volume API snapshots
Conflicts: Rakefile fog-openstack.gemspec lib/fog/openstack.rb lib/fog/openstack/image_v1.rb lib/fog/openstack/models/compute/availability_zone.rb lib/fog/openstack/models/compute/server.rb lib/fog/openstack/models/identity_v3/users.rb lib/fog/openstack/models/image_v2/image.rb lib/fog/openstack/models/volume/snapshot.rb lib/fog/openstack/models/volume/snapshots.rb lib/fog/openstack/models/volume/volume.rb lib/fog/openstack/models/volume_v1/snapshot.rb lib/fog/openstack/models/volume_v1/volume.rb lib/fog/openstack/models/volume_v2/snapshot.rb lib/fog/openstack/models/volume_v2/volume.rb lib/fog/openstack/network.rb lib/fog/openstack/requests/compute/create_snapshot.rb lib/fog/openstack/requests/compute/delete_flavor_metadata.rb lib/fog/openstack/requests/compute/get_key_pair.rb lib/fog/openstack/requests/compute/list_availability_zones.rb lib/fog/openstack/requests/compute/update_flavor_metadata.rb lib/fog/openstack/requests/volume/action.rb lib/fog/openstack/requests/volume/create_snapshot.rb lib/fog/openstack/requests/volume/delete_metadata.rb lib/fog/openstack/requests/volume/delete_snapshot_metadata.rb lib/fog/openstack/requests/volume/replace_metadata.rb lib/fog/openstack/requests/volume/update_metadata.rb lib/fog/openstack/requests/volume/update_snapshot.rb lib/fog/openstack/requests/volume/update_snapshot_metadata.rb lib/fog/openstack/requests/volume/update_volume.rb lib/fog/openstack/volume_v1.rb lib/fog/openstack/volume_v2.rb spec/fog/identity_v3/authv3_a.yml spec/fog/identity_v3/authv3_b.yml spec/fog/identity_v3/authv3_c.yml spec/fog/identity_v3/authv3_token.yml spec/fog/identity_v3/authv3_unscoped.yml spec/fog/identity_v3/authv3_unscoped_reauth.yml spec/fog/identity_v3/common_setup.yml spec/fog/identity_v3/idv3_credential_crud.yml spec/fog/identity_v3/idv3_domain_roles_mutation.yml spec/fog/identity_v3/idv3_endpoint.yml spec/fog/identity_v3/idv3_endpoints_crud.yml spec/fog/identity_v3/idv3_project.yml spec/fog/identity_v3/idv3_project_hier_crud_list.yml spec/fog/identity_v3/idv3_role.yml spec/fog/identity_v3/idv3_service.yml spec/fog/identity_v3/idv3_services_crud.yml spec/fog/identity_v3/idv3_token.yml spec/fog/identity_v3/idv3_user_crud.yml spec/fog/identity_v3/idv3_users.yml spec/fog/image_v1/common_setup.yml spec/fog/image_v1/list_images.yml spec/fog/image_v1_spec.rb spec/fog/image_v2/common_setup.yml spec/fog/image_v2/image_v2_create_id.yml spec/fog/image_v2/image_v2_crud.yml spec/fog/image_v2/image_v2_member_crudl.yml spec/fog/image_v2/image_v2_tags.yml spec/fog/network/common_setup.yml spec/fog/network_spec.rb spec/fog/volume/common_setup.yml spec/fog/volume/volume_crud.yml spec/fog/volume/volume_extend.yml spec/fog/volume/volume_transfer_and_accept.yml spec/fog/volume/volume_transfer_and_delete.yml spec/fog/volume/volume_type_read.yml spec/fog/volume_spec.rb spec/fog/volume_v1/common_setup.yml spec/fog/volume_v1/volume_crud.yml spec/fog/volume_v1/volume_extend.yml spec/fog/volume_v1/volume_transfer_and_accept.yml spec/fog/volume_v1/volume_type_read.yml spec/fog/volume_v2/common_setup.yml spec/fog/volume_v2/volume_crud.yml spec/fog/volume_v2/volume_extend.yml spec/fog/volume_v2/volume_transfer_and_accept.yml spec/fog/volume_v2/volume_transfer_and_delete.yml spec/fog/volume_v2/volume_type_read.yml spec/identity_v3_spec.rb spec/image_v2_spec.rb spec/image_v2_upload_spec.rb
…ent keystone policy adjustment.
First try to validate given token. If not successful, use old re-authenticate logic for compatibility reasons. The validation should keep the numbers of issued tokens in keystone much smaller, because a token will be reused instead of a new one is created.
upstream changes
DNS: crud recordsets
DNS: get zone
Carthaca
force-pushed
the
empty_public_ip_addresses
branch
from
2ded74f
to
fb61a4b
Compare
| # Fallback to standard authenticate to be compatible | ||
| if service | ||
| management_url = service['endpoints'].find { |e| e['interface']==endpoint_type }['url'] | ||
| identity_url = identity_service['endpoints'].find { |e| e['interface']=='public' }['url'] if identity_service |
There was a problem hiding this comment.
Surrounding space missing for operator ==.
|
Changes Unknown when pulling fb61a4b on sapcc:empty_public_ip_addresses into * on fog:master*. |
1 similar comment
|
Changes Unknown when pulling fb61a4b on sapcc:empty_public_ip_addresses into * on fog:master*. |
|
will do a new PR with a cherrypick |
|
see #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introducing a guard