Image::V1: Service type is now imagev1 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
Is this about image or volume? The code and the commit message seem to be about different services, right? |
aufi
approved these changes
Sep 26, 2018
|
@aufi I was talking about the PR description:
|
gildub
added a commit
that referenced
this pull request
Sep 27, 2018
…conflict [V0.3][Backport] #443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image service type v1 and v2 need to be differentiated.
Since openstack service type [1] doesn't offer an alias to distinguish between image v1 and v2 and because v1 is depreciate, let's keep the "image" service type to v2 and assign "imagev1" to v1.
While at it, let's also adds "imagev2" as a possible service type for v2.
#438
[1] https://git.openstack.org/cgit/openstack/service-types-authority/