Fixes #28121 - Fix convert_string_to_bool to deal with Array #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see issue: #62 |
|
@orrabin , @ShimShtein please review :) |
shiramax
force-pushed
the
28121
branch
2 times, most recently
from
523b88b
to
34b3c8d
Compare
orrabin
approved these changes
Oct 28, 2019
ShimShtein
reviewed
Oct 28, 2019
lib/fog/ovirt/compute/v4.rb
Outdated
| convert_string_to_bool(value) | ||
| elsif value.is_a? Array | ||
| value.map { |item| convert_string_to_bool(item) } | ||
| if opts.is_a? Hash |
There was a problem hiding this comment.
def convert_string_to_bool(value)
case value
when "true"
return true
when "false"
return false
when Array
return value.map { |elem| convert_string_to_bool(elem) }
when Hash
value.each do |key, elem|
value[key] = convert_string_to_bool(elem)
end
return value
else
return value
end
end
|
thanks @ShimShtein, can you please review again :) ? |
|
merged, Thanks @shiramax! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a bug in the convert_string_to_bool function. ATM the function It doesn't validate the data type of the item in value.map (when it's an array). It caused the same error. It happens when deploying a host to oVirt (from Foreman 1.23):
NoMethodError: undefined method
each' for #<Fog::Ovirt::Compute::Interface:0x007f0b76120628> /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/compute/v4.rb:116:inconvert_string_to_bool'/usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/compute/v4.rb:124:in
block (2 levels) in convert_string_to_bool' /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-core-2.1.0/lib/fog/core/collection.rb:18:inmap'/usr/share/foreman/vendor/ruby/2.3.0/gems/fog-core-2.1.0/lib/fog/core/collection.rb:18:in
map' /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/compute/v4.rb:124:inblock in convert_string_to_bool'/usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/compute/v4.rb:116:in
each' /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/compute/v4.rb:116:inconvert_string_to_bool'/usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/requests/compute/v4/update_vm.rb:9:in
update_vm' /usr/share/foreman/vendor/ruby/2.3.0/gems/fog-ovirt-1.2.1/lib/fog/ovirt/models/compute/server.rb:177:insave'/usr/share/foreman/app/models/compute_resources/foreman/model/ovirt.rb:242:in `start_vm'