fix clone vm without datastore relocation

[timogoebel]

Fixes #132.

This commit checks if the new_volume has a datastore attribute before trying to relocate it.

The error in the issue happens, because this is passed to vSphere (because new_volume.datastore is nil):

relocation_spec[:disk] -> [{:diskId=>nil, :datastore=>nil}]

[timogoebel]

@scambra: Do you mind taking a look? Does this still work with your use case?

[chris1984]

@timogoebel I am hitting this:

/home/chrobert/.rvm/gems/ruby-2.4.3/gems/fog-vsphere-2.0.1/lib/fog/vsphere/requests/compute/vm_clone.rb:134:in `vm_clone': undefined method `parent' for nil:NilClass (NoMethodError)

I sent you a PM on IRC with my file, let me know if its something I am doing wrong ( more than likely) as I am not seeing any reference to parent in this PR. I will be online at 9 AM EST tomorrow.

[chris1984]

Thanks @timogoebel tested and working

[kartikaydw]

Hey There,

I am getting below error while attaching the disk. Any Pointers?

**Required property id is missing from data object of type ID

while parsing serialized DataObject of type vim.vslm.ID
at line 1, column 255

while parsing call information for method AttachDisk_Task
at line 1, column 177

while parsing SOAP body
at line 1, column 167

while parsing SOAP envelope
at line 1, column 0

while parsing HTTP request for method attachDisk
on object of type vim.VirtualMachine
at line 1, column 0**

Code snippet.

 vm.AttachDisk_Task(
    diskId: did,
    datastore: vmdk_datastore,
    controllerKey: 1000,
    unitNumber: 14,

)