Add :endpoint to the options hash for Local Storage

[novemberkilo]

If endpoint is nil, files loaded to Local Storage
have a public_url of nil. Specifying a value for :endpoint
in the options hash fixes this.

Also please see my comment on

fog/fog@61ff93a

Seeing this in the documentation would have saved me a couple of hours.

Not sure the pull request is appropriate - just thought it would make my suggested change very clear.

Thanks!

[geemus]

@novemberkilo - cool, could you also add some additional text explaining how the value ends up getting used? Also if it explained that this was optional I think that might be helpful to avoid any additional confusion. Thanks!

[admtnnr]

When I added support for public_url to local storage I thought of endpoint as being the root URL that gets joined with the path to the actual file. So if you stored your files in ~/.fog (local root) and were accessible as http://example.com/files/ then a file located at ~/.fog/pictures/summer/1.jpg it would be accessible as http://example.com/files/pictures/summer/1.jpg. Endpoint may have been the wrong name, maybe something like remote_root?

[novemberkilo]

@geemus @adamtanner have added to the text as suggested.

[geemus]

@novemberkilo - awesome, thanks!

@adamtanner - interesting. I think it could make sense to change to something like remote_root, which is likely to be a bit clearer as you said. We should make sure if/when we do to still support endpoint though, at least for the time being, but probably with a deprecation warning. Let me know if you decide to tackle that and have any questions or anything.