Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibVirt has been added as a dependency by accident #2316

Closed
tokengeek opened this issue Oct 24, 2013 · 1 comment · Fixed by #2317
Closed

LibVirt has been added as a dependency by accident #2316

tokengeek opened this issue Oct 24, 2013 · 1 comment · Fixed by #2317
Assignees
@tokengeek

Comments

@tokengeek
Copy link
Member

In b373e55 to guard against JRUBY using ruby-libvirt the comment was removed.

This has made ruby-libvirt a dependency for everyone again.

Fix shortly...
@ghost ghost assigned tokengeek Oct 24, 2013
tokengeek added a commit that referenced this issue Oct 24, 2013
@tokengeek
[core] Make ruby-libvirt dependency optional
77d1708 
The `ruby-libvirt` dependency was commented out since it is rarely used
and a pain for developers to prepare.

The comment was removed in b373e55
to protect JRuby but made it a requirement for MRI (& others).

This adds another guard based around the setting of `FOG_USE_LIBVIRT`
environment variable.

This hopefully will mean anyone wanting to use it can just set that
rather than editing the gemspec.

Fixes #2316
@tokengeek tokengeek mentioned this issue Oct 24, 2013
Merged
@krames
Copy link
Member

krames commented Oct 24, 2013

@tokengeek Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tokengeek tokengeek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Make ruby-libvirt dependency optional fog/fog
2 participants
@tokengeek @krames