[storage|aws] Support overriding request parameters

[kneath]

I was looking to create a signed url that included a response-content-disposition request parameter override so that I could change the filename that the browser downloaded. You can see examples of this on Amazon's documentation: http://docs.amazonwebservices.com/AmazonS3/latest/API/index.html?RESTObjectGET.html

… but I ran into no amount of issues, probably due to my misunderstanding of Fog. But I'm pretty sure that fog doesn't allow this query param. It would be nice to support request parameter overrides in get_object_url or even url.

The way I was trying (which failed, due to the fact that params[:query] was a string that didn't have keys — and using a hash mashed my key/value together without a = breaking the request):

storage = Fog::Storage.new(:provider => 'AWS', :aws_access_key_id => S3_ACCESS_KEY, :aws_secret_access_key => S3_SECRET)

expires = Time.now + 30*24*60*60
url = storage.url({
            :headers  => {},
            :host     => 's3.amazonaws.com',
            :method   => 'GET',
            :path     => "#{S3_BUCKET}/#{Release.latest_release.guid}.zip",
            :query    => 'response-content-disposition=attachment%3B%20filename%3Dtest.zip'
          }, expires)

The end result was that it seemed impossible to get a &response-content-disposition=attachment%3B%20filename%3Dtest.zip into the url string to be signed.

[geemus]

That commit should fix it so that you can pass a hash as the query (with the content related stuff in there) and have it do the right thing. Will try to get a release out later this week (probably tomorrow or Thursday, but have a few more things to review/merge). Thanks!

[masterkain]

geemus@8fb8642#L0R68 supposes that params[:query] exists, while this might not hold true. I was hacking Paperclip to expose the computed and private url of attachment and found this.

My suggested fix is to declare params[:query] ||= {} on line 66.

[geemus]

good catch, here is the fix: geemus@73b30b1