[openstack] Volume API uses Fog::Compute::OpenStack::NotFound exception class

[majewsky]

lib/fog/openstack/volume.rb#L177 has what is probably just a copy-paste error:

rescue Excon::Errors::HTTPStatusError => error
  raise case error
  when Excon::Errors::NotFound
    Fog::Compute::OpenStack::NotFound.slurp(error)
  else
    error
  end

That custom exception class should be Fog::Volume::OpenStack::NotFound.(with Volume instead of Compute). Since that class already exists and is used in a few other places, I don't see an easy way to fix that in a backwards-compatible way. So it should at least be noted and fixed when backwards compatibility is broken the next time.

[TerryHowe]

Too bad there isn't a Fog::OpenStack::NotFound

[geemus]

I guess you could raise it but make it a subclass of excon not found, but that seems pretty weird/bad also.

[Carthaca]

I noticed this copy-paste error also in the following services: baremetal, image, metering, orchestration and planning

[geemus]

@d063130 good eye, we'll try to fix those as well when we make the change.

[plribeiro3000]

Closing in favor of fog/fog-openstack#48